Skip to content

Conversation

@ecoussoux-ansys
Copy link
Contributor

This PR provides a fix for #6780 by introducing an error message in case the cutout extension is started on an empty HFSS 3D Layout design.

This case is not supported by the __load_objects_net() method (which is part of the __init__() of the extension) responsible for loading the objects by net from the EDB modeler: Therefore an error is now raised to avoid subsequent crash of the code in this situation.
A corresponding unit test is added.

Close #6780.

@ecoussoux-ansys ecoussoux-ansys self-assigned this Oct 27, 2025
@ecoussoux-ansys ecoussoux-ansys requested a review from a team as a code owner October 27, 2025 17:16
@ecoussoux-ansys ecoussoux-ansys added the bug Something isn't working label Oct 27, 2025
eblanco-ansys
eblanco-ansys previously approved these changes Oct 27, 2025
@eblanco-ansys
Copy link
Contributor

LGTM

@codecov
Copy link

codecov bot commented Oct 27, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.49%. Comparing base (8d8e574) to head (d34f5e8).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6822   +/-   ##
=======================================
  Coverage   83.49%   83.49%           
=======================================
  Files         245      245           
  Lines       77506    77509    +3     
=======================================
+ Hits        64710    64713    +3     
  Misses      12796    12796           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@eblanco-ansys eblanco-ansys merged commit 3241dff into main Oct 30, 2025
70 of 71 checks passed
@eblanco-ansys eblanco-ansys deleted the fix/cutout-extension-with-empty-design branch October 30, 2025 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working extensions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug in cutout extension

5 participants